Skip to content

[stable-3.10] rich workspaces#5152

Merged
tobiasKaminsky merged 5 commits into
stable-3.10from
backport/5130/stable-3.10
Jan 10, 2020
Merged

[stable-3.10] rich workspaces#5152
tobiasKaminsky merged 5 commits into
stable-3.10from
backport/5130/stable-3.10

Conversation

@backportbot-nextcloud

@backportbot-nextcloud backportbot-nextcloud Bot commented Jan 10, 2020

Copy link
Copy Markdown

backport of #5130

@tobiasKaminsky
rich workspaces
f1ad246 
- show button to create folder info
- bug fixes

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
fix FAB position
c4e2bcc 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
better error description
7e1a991 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
manually increasing lint due to "autoMirrored" warning
5b3ab77 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
only allow rich workspace creation on >= Lollipop
1df7af1 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@backportbot-nextcloud backportbot-nextcloud Bot added this to the Nextcloud App 3.10.0 milestone Jan 10, 2020
@backportbot-nextcloud backportbot-nextcloud Bot mentioned this pull request Jan 10, 2020
Merged
@nextcloud-android-bot

nextcloud-android-bot commented Jan 10, 2020

Copy link
Copy Markdown
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12228.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot

nextcloud-android-bot commented Jan 10, 2020

Copy link
Copy Markdown
Collaborator

Lint

Typestable-3.10PR
Warnings7476
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

SpotBugs (stable-3.10)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

@codecov

codecov Bot commented Jan 10, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5152 into stable-3.10 will decrease coverage by 0.69%.
The diff coverage is 8.69%.

@@               Coverage Diff               @@
##             stable-3.10   #5152     +/-   ##
===============================================
- Coverage          17.69%     17%   -0.7%     
  Complexity             3       3             
===============================================
  Files                392     392             
  Lines              33116   33134     +18     
  Branches            4651    4655      +4     
===============================================
- Hits                5861    5635    -226     
- Misses             26300   26591    +291     
+ Partials             955     908     -47
Impacted Files Coverage Δ Complexity Δ
.../owncloud/android/ui/activity/TextEditorWebView.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...ndroid/ui/activity/RichDocumentsEditorWebView.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...om/owncloud/android/ui/activity/EditorWebView.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java 24.57% <9.09%> (-0.63%) 0 <0> (ø)
...services/firebase/NCFirebaseInstanceIDService.java 0% <0%> (-87.5%) 0% <0%> (ø)
...ava/com/owncloud/android/utils/DataHolderUtil.java 0% <0%> (-82.36%) 0% <0%> (ø)
...va/com/owncloud/android/ui/SquareLinearLayout.java 0% <0%> (-50%) 0% <0%> (ø)
...oud/android/operations/RefreshFolderOperation.java 44.71% <0%> (-14.64%) 0% <0%> (ø)
.../services/firebase/NCFirebaseMessagingService.java 0% <0%> (-7.15%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 25.91% <0%> (-6.39%) 0% <0%> (ø)
... and 16 more

@tobiasKaminsky
tobiasKaminsky merged commit dbb71e3 into stable-3.10 Jan 10, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the backport/5130/stable-3.10 branch January 10, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger
@juliusknorr juliusknorr Awaiting requested review from juliusknorr
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud App 3.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@nextcloud-android-bot @tobiasKaminsky